Add version info in the left top of dashboard, like this: Sentinel 控制台 1.7.0 #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
added
area/dashboard
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
============================================
- Coverage 42.72% 42.67% -0.06%
Complexity 1473 1473
============================================
Files 317 317
Lines 9280 9280
Branches 1267 1267
============================================
- Hits 3965 3960 -5
- Misses 4825 4828 +3
- Partials 490 492 +2
Continue to review full report at Codecov.
|
sczyh30
reviewed
Aug 27, 2019
| @@ -1,6 +1,13 @@ | |||
| var app = angular.module('sentinelDashboardApp'); | |||
|
|
|||
| app.service('AuthService', ['$http', function ($http) { | |||
| this.version = function () { | |||
There was a problem hiding this comment.
Can we put this API to another service like VersionService? It's actually not related to auth.
There was a problem hiding this comment.
Thanks for the guidance, that is more clever, I fix it, please review 🌹
cdfive
approved these changes
Aug 29, 2019
sczyh30
approved these changes
Aug 29, 2019
|
Resolves #728 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
#728
look like:
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews