Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1059 #1061

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Fix issue #1059 #1061

merged 1 commit into from
Sep 21, 2019

Conversation

HaojunRen
Copy link
Contributor

Fix issue #1059

@codecov-io
Copy link

Codecov Report

Merging #1061 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1061   +/-   ##
========================================
  Coverage      43.1%   43.1%           
+ Complexity     1493    1492    -1     
========================================
  Files           317     317           
  Lines          9295    9295           
  Branches       1269    1269           
========================================
  Hits           4007    4007           
  Misses         4794    4794           
  Partials        494     494
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/LeapArray.java 67.32% <0%> (-2.98%) 33% <0%> (-1%)
...p/sentinel/datasource/consul/ConsulDataSource.java 69.56% <0%> (+4.34%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33ed81...c6507f4. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 582f32c into alibaba:master Sep 21, 2019
@sczyh30
Copy link
Member

sczyh30 commented Sep 21, 2019

Thanks!

@sczyh30 sczyh30 added the dependencies Pull requests that update a dependency file label Oct 31, 2019
hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants