Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改了可写FileDataSource #125

Merged
merged 5 commits into from
Sep 5, 2018
Merged

修改了可写FileDataSource #125

merged 5 commits into from
Sep 5, 2018

Conversation

yfh0918
Copy link
Contributor

@yfh0918 yfh0918 commented Sep 4, 2018

Describe what this PR does / why we need it

See #75

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

2:增加了钩子函数refresh(AutoRefreshDataSource和FileRefreshableDataSource)
@sczyh30 sczyh30 added the to-review To review label Sep 4, 2018
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat your code with Alibaba P3C Plugin and obey the rules in Alibaba Java Coding Guidelines (naming, indent, format, etc.).

@codecov-io
Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #125 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #125      +/-   ##
============================================
+ Coverage     45.67%   45.83%   +0.15%     
- Complexity      554      556       +2     
============================================
  Files           114      114              
  Lines          3814     3814              
  Branches        531      531              
============================================
+ Hits           1742     1748       +6     
+ Misses         1859     1855       -4     
+ Partials        213      211       -2
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/LeapArray.java 76.92% <0%> (+5.12%) 15% <0%> (+1%) ⬆️
...ibaba/csp/sentinel/eagleeye/EagleEyeLogDaemon.java 30.3% <0%> (+6.06%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a27f39...fb21228. Read the comment docs.

@sczyh30 sczyh30 merged commit 175452a into alibaba:master Sep 5, 2018
@sczyh30 sczyh30 removed the to-review To review label Sep 5, 2018
@sczyh30
Copy link
Member

sczyh30 commented Sep 5, 2018

Thanks for your contribution!

Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
…#125)

- Add method to check if the resource is modified in `AutoRefreshDataSource`
- Implement FileWritableDataSource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants