Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1321 新增Client IP 和 Remote Host的具体属性值 #1324

Closed
wants to merge 1 commit into from
Closed

Fixes #1321 新增Client IP 和 Remote Host的具体属性值 #1324

wants to merge 1 commit into from

Conversation

jy2156121
Copy link
Contributor

@jy2156121 jy2156121 commented Mar 7, 2020

Describe what this PR does / why we need it

在编辑网关流控规则中
参数属性中的Client IP 和 Remote Host不能设置具体的属性值,Hearder、URL参数、Cookie中可以设置

Does this pull request fix one issue?

Fixes #1321

Describe how you did it

Describe how to verify it

Special notes for reviews

在编辑网关流控规则中
参数属性中的Client IP 和 Remote Host不能设置具体的属性值,Hearder、URL参数、Cookie中可以设置
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zry seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jy2156121 jy2156121 changed the title Fixes #1321 Fixes #1321 新增Client IP 和 Remote Host的具体属性值 Mar 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #1324 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1324      +/-   ##
============================================
+ Coverage     43.05%   43.08%   +0.02%     
- Complexity     1625     1627       +2     
============================================
  Files           350      350              
  Lines         10295    10295              
  Branches       1389     1389              
============================================
+ Hits           4433     4436       +3     
+ Misses         5310     5307       -3     
  Partials        552      552
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/LeapArray.java 67.32% <0%> (-2.98%) 33% <0%> (-1%)
...tinel/slots/block/flow/param/ParamFlowChecker.java 55.4% <0%> (+2.7%) 29% <0%> (+1%) ⬆️
...m/alibaba/csp/sentinel/log/DateFileLogHandler.java 57.57% <0%> (+3.03%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0d116...a296bf1. Read the comment docs.

@sczyh30 sczyh30 added the area/gateway-flow-control Issues or PRs related to API gateway flow control label Mar 7, 2020
@jy2156121 jy2156121 closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-flow-control Issues or PRs related to API gateway flow control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

控制台网关流控规则对话框支持配置 Client IP 和 Host 的具体属性值匹配
4 participants