-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature add Quarkus integration #1444
Conversation
@@ -0,0 +1,9 @@ | |||
# references for build native image or AOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
@sczyh30 native image is supported. native image test is currently added in sentinel-demo-quarkus. just run |
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
============================================
+ Coverage 43.80% 44.42% +0.62%
- Complexity 1703 1775 +72
============================================
Files 372 378 +6
Lines 10605 10828 +223
Branches 1414 1454 +40
============================================
+ Hits 4645 4810 +165
- Misses 5393 5432 +39
- Partials 567 586 +19
Continue to review full report at Codecov.
|
Cool! I'll take a look these days :) |
@seasidesky Could you please squash the PR to three commits:
|
OK |
@sczyh30 split to three pull requests
|
[ISSUES alibaba#1439]fix transaction typo
Describe what this PR does / why we need it
feature add Quarkus integration
Does this pull request fix one issue?
fix #1233
Describe how you did it
sentinel-annotation-cdi-interceptor
to support@SentinelResourceBinding
for CDI, corresponding tosentinel-annotation-aspectj
and@SentinelResource
sentinel-quarkus-adapter
module, it providessentinel-annotation-quarkus-adapter
andsentinel-jax-rs-quarkus-adapter
to adaptsentinel-annotation-cdi-interceptor
andsentinel-jax-rs-adapter
for quarkus.sentinel-quarkus-adapter
also providessentinel-native-image-quarkus-adapter
to support running sentinel with quarkus in native image mode.sentinel-demo-annotation-cdi-interceptor
andsentinel-demo-quarkus
are addedDescribe how to verify it
all test run pass
Special notes for reviews
sentinel-demo-quarkus
sentinel-native-image-quarkus-adapter
currently rely onsentinel-logging-slf4j
to make sentinel run in native image mode easily, becausequarkus-core
providesTarget_org_slf4j_LoggerFactory
to substituegetLogger
method.sentinel-transport-simple-http
can work in native image mode, whilesentinel-transport-netty-http
cannot work in native image mode without extra config or substitutions.