-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Adapter] Support motan RPC #1825
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2、the design is reference dubbo
Closed
sczyh30
added
area/integrations
Issues or PRs related to integrations with open-source components
to-review
To review
labels
Oct 29, 2020
Closed
cdfive
reviewed
Nov 7, 2020
...otan-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/MotanAppContextFilter.java
Outdated
Show resolved
Hide resolved
cdfive
reviewed
Nov 7, 2020
...dapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/SentinelMotanConsumerFilter.java
Outdated
Show resolved
Hide resolved
cdfive
reviewed
Nov 7, 2020
...dapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/SentinelMotanProviderFilter.java
Outdated
Show resolved
Hide resolved
cdfive
reviewed
Nov 7, 2020
...dapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/SentinelMotanProviderFilter.java
Outdated
Show resolved
Hide resolved
cdfive
reviewed
Nov 7, 2020
cdfive
reviewed
Nov 7, 2020
cdfive
reviewed
Nov 7, 2020
...mo-motan/src/main/java/com/alibaba/csp/sentinel/demo/motan/SentinelMotanConsumerService.java
Outdated
Show resolved
Hide resolved
cdfive
reviewed
Nov 7, 2020
...otan-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/MotanAppContextFilter.java
Outdated
Show resolved
Hide resolved
cdfive
reviewed
Nov 8, 2020
...dapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/SentinelMotanProviderFilter.java
Outdated
Show resolved
Hide resolved
cdfive
reviewed
Nov 8, 2020
...dapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/SentinelMotanProviderFilter.java
Outdated
Show resolved
Hide resolved
cdfive
reviewed
Nov 8, 2020
...dapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/SentinelMotanProviderFilter.java
Outdated
Show resolved
Hide resolved
2、format comment
Run the demo and it works well, and I have no further idea. |
sczyh30
requested changes
Nov 10, 2020
...an-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/BaseMotanSentinelFilter.java
Outdated
Show resolved
Hide resolved
...an-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/BaseMotanSentinelFilter.java
Outdated
Show resolved
Hide resolved
...an-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/motan/BaseMotanSentinelFilter.java
Outdated
Show resolved
Hide resolved
sczyh30
approved these changes
Dec 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice work. Thanks for contributing! |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2、the design is reference dubbo
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews