-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature spring cloud zuul adapter #188
Feature spring cloud zuul adapter #188
Conversation
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
============================================
+ Coverage 37.05% 38.24% +1.18%
- Complexity 940 992 +52
============================================
Files 224 235 +11
Lines 7221 7407 +186
Branches 984 1014 +30
============================================
+ Hits 2676 2833 +157
+ Misses 4207 4205 -2
- Partials 338 369 +31
Continue to review full report at Codecov.
|
Thanks for contributing. I'll do the review these days. |
this pr has decoupled sentinel zuul adapter from Spring Cloud Zuul. the Spring Cloud Zuul adapter will put into spring cloud alibaba project and dependant with this adapter. |
这个adapter什么时候可以搞定? |
...er/src/main/java/com/alibaba/csp/sentinel/adapter/zuul/fallback/SentinelFallbackManager.java
Outdated
Show resolved
Hide resolved
...adapter/src/main/java/com/alibaba/csp/sentinel/adapter/zuul/filters/SentinelErrorFilter.java
Outdated
Show resolved
Hide resolved
...adapter/src/main/java/com/alibaba/csp/sentinel/adapter/zuul/filters/SentinelErrorFilter.java
Show resolved
Hide resolved
...-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/zuul/filters/SentinelPostFilter.java
Outdated
Show resolved
Hide resolved
...l-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/zuul/filters/SentinelPreFilter.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Awesome, thanks for contributing! |
@tigerMoon Could you please add Chinese document here: https://github.com/sentinel-group/sentinel-website/blob/master/docs/zh-cn/open-source-framework-integrations.md We'll merge this with wiki later. |
Describe what this PR does / why we need it
Spring cloud zuul lack the capability of flow control. this starter implements this.
Does this pull request fix one issue?
Fixes #63
Describe how you did it
Implement
ZuulFilter
at pre, post, and error phase. provide ServiceId and API PATH level flow control.Describe how to verify it
Special notes for reviews
no