fix flaky test in SentinelConfigTest #1884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
requested changes
Dec 16, 2020
| @@ -19,6 +21,16 @@ | |||
| */ | |||
| public class SentinelConfigTest { | |||
|
|
|||
| @Before | |||
| public void setUp() { | |||
| SentinelConfig.setConfig(SentinelConfig.COLD_FACTOR, SentinelConfig.DEFAULT_CHARSET); | |||
There was a problem hiding this comment.
The default value should be DEFAULT_COLD_FACTOR.
|
Any feedback? |
|
Closing the issue due to no further feedback. |
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
…ipeWritePerm_desc [ISSUE alibaba#1883] Doc error about admin tool WipeWritePermSubCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed flaky test testDefaultConfig that caused by testColdFactoryLargerThanOne in SentinelConfigTest
If we run testColdFactoryLargerThanOne first, it will modify SentinelConfig.COLD_FACTOR.
Then when we run testDefaultConfig, the code assertEquals(SentinelConfig.DEFAULT_CHARSET, SentinelConfig.charset()) will have issue.
The flaky tests are found by running https://github.com/idflakies/iDFlakies
Describe how you did it:
Set a before and after method to set the variables to the default value.