Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue of memory leak in real-time monitoring page of Sentinel dashboard #1905

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Fix issue of memory leak in real-time monitoring page of Sentinel dashboard #1905

merged 2 commits into from
Dec 28, 2020

Conversation

zhangkai253
Copy link
Contributor

fix issue of memory leak about realtime monitor page

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zhangkai253 zhangkai253 mentioned this pull request Dec 16, 2020
Closed
@sczyh30
Copy link
Member

sczyh30 commented Dec 17, 2020

Could you please describe your design in the PR description?

@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Dec 17, 2020
@zhangkai253
Copy link
Contributor Author

Could you please describe your design in the PR description?

just revoke useless charts positively, otherwise charts will accumulate more and more

@sczyh30
Copy link
Member

sczyh30 commented Dec 18, 2020

Could you please describe your design in the PR description?

just revoke useless charts positively, otherwise charts will accumulate more and more

Nice. Could you please add a brief comment in your code?

@sczyh30 sczyh30 changed the title fix issue of memory leak Fix issue of memory leak in real-time monitoring page of Sentinel dashboard Dec 18, 2020
@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Dec 18, 2020
@sczyh30 sczyh30 linked an issue Dec 18, 2020 that may be closed by this pull request
chrome out of memory #1879
Closed
@zhangkai253
Copy link
Contributor Author

Could you please describe your design in the PR description?

just revoke useless charts positively, otherwise charts will accumulate more and more

Nice. Could you please add a brief comment in your code?

have done

@sczyh30 sczyh30 requested a review from cdfive December 18, 2020 03:38
sczyh30
sczyh30 approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 63aeb49 into alibaba:master Dec 28, 2020
@sczyh30
Copy link
Member

sczyh30 commented Dec 28, 2020

Thanks for contributing!

shenbaoyong pushed a commit to shenbaoyong/Sentinel that referenced this pull request Feb 5, 2021
@zhangkai253 @shenbaoyong
dashboard: Fix issue of memory leak in real-time monitoring page (ali…
3469fd9 
…baba#1905)

* Fix issue of memory leak in metric.js
hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
@zhangkai253
dashboard: Fix issue of memory leak in real-time monitoring page (ali…
a96fd18 
…baba#1905)

* Fix issue of memory leak in metric.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sczyh30 sczyh30 sczyh30 approved these changes

@cdfive cdfive Awaiting requested review from cdfive

Assignees
No one assigned
Labels
area/dashboard Issues or PRs about Sentinel Dashboard kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chrome out of memory
3 participants
@zhangkai253 @CLAassistant @sczyh30