Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for resource page in Sentinel Dashboard #209

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Oct 30, 2018

Describe what this PR does / why we need it

Add support for adding parameter flow rule and authority rule in resource (identity) page of Sentinel dashboard.

Does this pull request fix one issue?

Closes #208

Describe how you did it

  • Add button and logic for adding param rule / authority rule in resource page
  • Decouple rule checking logic from frontend controller to services to reuse the logic
  • Fix bugs and adapt to field changes

Describe how to verify it

Run the dashboard.

Special notes for reviews

None.

…f dashboard

- Decouple rule checking from controller (now in service)

Signed-off-by: Eric Zhao <[email protected]>
@sczyh30 sczyh30 added the to-review To review label Oct 30, 2018
@sczyh30 sczyh30 added this to the 1.3.0 milestone Oct 30, 2018
@sczyh30 sczyh30 force-pushed the dashboard/enhance-resource-page branch from 822a598 to 5ab4de3 Compare October 30, 2018 06:04
@sczyh30 sczyh30 force-pushed the dashboard/enhance-resource-page branch from 5ab4de3 to f9638e5 Compare October 30, 2018 06:36
Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit d432750 into master Oct 30, 2018
@sczyh30 sczyh30 deleted the dashboard/enhance-resource-page branch October 30, 2018 06:52
@sczyh30 sczyh30 removed the to-review To review label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

控制台没有权限控制配置页面和按钮
2 participants