Support private blockHandler/fallback method for @SentinelResource annotation #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sczyh30
added
area/annotation
sczyh30
changed the title
wuwen5
force-pushed
the
fallback-support-private-method
branch
from
bb3a025
to
579c2f4
Compare
|
cc for review @jasonjoo2010 @cdfive @brotherlu-xcq |
brotherlu-xcq
requested changes
Jun 3, 2021
...src/main/java/com/alibaba/csp/sentinel/annotation/aspectj/AbstractSentinelAspectSupport.java
Outdated
Show resolved
Hide resolved
wuwen5
force-pushed
the
fallback-support-private-method
branch
from
579c2f4
to
088a9e8
Compare
...src/main/java/com/alibaba/csp/sentinel/annotation/aspectj/AbstractSentinelAspectSupport.java
Outdated
Show resolved
Hide resolved
wuwen5
force-pushed
the
fallback-support-private-method
branch
from
088a9e8
to
9ee2c8f
Compare
|
Nice work. Thanks for contributing and look forward to more! |
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 16, 2021
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
…libaba#2163) Co-authored-by: hechengyang <[email protected]>
Zhang-0952
pushed a commit
to Zhang-0952/Sentinel
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
fallback method should be private
Does this pull request fix one issue?
NONE
Describe how you did it
Refer to Resilience4j and Hystrix.
Describe how to verify it
SentinelAnnotationIntegrationTest#testFallBackPrivateMethod