-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support prioritized entry in ProcessorSlot interface #255
Conversation
- Add `entryWithPriority` in SphU Signed-off-by: Eric Zhao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
============================================
+ Coverage 51.78% 52.42% +0.63%
- Complexity 894 903 +9
============================================
Files 150 150
Lines 5030 5036 +6
Branches 723 723
============================================
+ Hits 2605 2640 +35
+ Misses 2110 2077 -33
- Partials 315 319 +4
Continue to review full report at Codecov.
|
Signed-off-by: Eric Zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Refactor the slot interface to support prioritized entry - Add `entryWithPriority` in SphU Signed-off-by: Eric Zhao <[email protected]>
Describe what this PR does / why we need it
Support prioritized entry in ProcessorSlot interface so that each slot can handle requests with priority.
Does this pull request fix one issue?
Related to #207
Describe how you did it
ProcessorSlot
interface (add a parameterprioritized
in entry-related methods)entryWithPriority
methods inSphU
(separate fromentry
method so that it won't be confused with previousentry
with args)Describe how to verify it
This is only a change for interface. Run all test cases to ensure nothing broken.
Special notes for reviews
NONE