Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复移除TokenServer失败的问题 #2591

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

icodening
Copy link
Contributor

Describe what this PR does / why we need it

Bug fix #2590

Does this pull request fix one issue?

Fixes #2590

Describe how you did it

原本 com.alibaba.csp.sentinel.dashboard.util.ClusterEntityUtils的wrapToClusterGroup 中的map中的Key用的是实例的ip,并非ip:port,导致同机器下不同端口时,同IP的信息会被覆盖。
只需修改 com.alibaba.csp.sentinel.dashboard.util.ClusterEntityUtils的wrapToClusterGroup方法,将Key改为ip port,使其可以正常返回结果

Describe how to verify it

部署Dashboard之后无论先从哪个实例删除均成功即可

Special notes for reviews

@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Mar 9, 2022
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 added this to the 1.8.4 milestone Mar 15, 2022
@sczyh30 sczyh30 merged commit 42878a2 into alibaba:master Mar 15, 2022
@sczyh30
Copy link
Member

sczyh30 commented Mar 15, 2022

Thanks for contributing!

@icodening icodening deleted the bugfix-remove_token_server branch March 15, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentinel Dashboard在特定场景下移除Token Server一定失败
2 participants