Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the method isValidRule in GatewayRuleManager.class has a invalid … #2609

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

DollarB
Copy link
Contributor

@DollarB DollarB commented Mar 18, 2022

Describe what this PR does / why we need it
Fix the method isValidRule in GatewayRuleManager.class has a invalid check. ControlBehavior should be checked here, not grade.

Does this pull request fix one issue?
Fixes #2595

…check. ControlBehavior should be checked here, not grade. (alibaba#2595)
@sczyh30 sczyh30 added the kind/bug Category issues or prs related to bug. label Mar 21, 2022
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit ab6c9ad into alibaba:master Mar 22, 2022
@sczyh30 sczyh30 added this to the 1.8.4 milestone Mar 22, 2022
@sczyh30
Copy link
Member

sczyh30 commented Mar 22, 2022

Thanks for contributing!

@DollarB DollarB deleted the fix_#2595_bug branch March 22, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Bug:The method isValidRule(GatewayFlowRule rule) in GatewayRuleManager.class has a invalid check.
2 participants