Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修正closeResources方法中无法打印首次异常 #2890

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

hongpy
Copy link
Contributor

@hongpy hongpy commented Sep 26, 2022

修改closeResources方法中的if判断

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2022

CLA assistant check
All committers have signed the CLA.

@sczyh30
Copy link
Member

sczyh30 commented Sep 26, 2022

Could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=2890

@sczyh30 sczyh30 linked an issue Sep 26, 2022 that may be closed by this pull request
@sczyh30 sczyh30 added the kind/bug Category issues or prs related to bug. label Sep 26, 2022
@sczyh30
Copy link
Member

sczyh30 commented Sep 26, 2022

It could be better if you could add test cases for it as well.

@sczyh30 sczyh30 requested a review from cdfive September 26, 2022 11:23
Copy link
Collaborator

@cdfive cdfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for pointing it out and help fixing it! @hongpy @sczyh30

@sczyh30 sczyh30 merged commit 5864ab5 into alibaba:master Oct 9, 2022
@sczyh30
Copy link
Member

sczyh30 commented Oct 9, 2022

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentinel-core,spi -> SpiLoader-> closeResources方法 有小错误
4 participants