Add implementation of token bucket for flow-control #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sczyh30
changed the title
sczyh30
added
kind/feature
|
Thanks for contributing! |
LearningGp
added a commit
that referenced
this pull request
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This PR adds a simple implementation of the token bucket algorithm.
The biggest advantage of sentinel's sliding window data structure is that it can handle some extreme high concurrency scenarios, so we pay some performance costs, but in some scenarios, we need more statistical dimensions and do not care about extreme high concurrency scenarios. In these scenarios, the implementation of a lightweight token bucket algorithm may be a better choice.
Does this pull request fix one issue?
This PR is a pre-work to fix the following issues:
#263
#2231
Describe how you did it
In the implementation, the number of tokens in the token bucket is not continuously updated, it will be calculated at the time of acquisition, thereby reducing the overall performance costs.
Describe how to verify it
Run the test cases.
Special notes for reviews