Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support run test at jdk21 #3344

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Support run test at jdk21 #3344

merged 4 commits into from
Feb 20, 2024

Conversation

robberphex
Copy link
Collaborator

@robberphex robberphex commented Feb 20, 2024 •
edited
Loading

Describe what this PR does / why we need it

Support JDK21:

  1. Adjust the test logic, build with jdk17, and run with jdk21 (and the original 8, 11, 17)
  2. In order to run well in jdk21, upgrade mockito to 4.11.0 and byte-buddy to 1.14.10
Chinese/中文

支持JDK21:

  1. 调整测试逻辑，使用jdk17构建，jdk21（以及原有的8、11、17）运行
  2. 为了能够在jdk21上跑通，mockito升级到4.11.0，byte-buddy升级到1.14.10

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@robberphex robberphex changed the title support Jdk21 Support run test at jdk21 Feb 20, 2024
panxiaojun233
panxiaojun233 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@panxiaojun233 panxiaojun233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LearningGp
LearningGp approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp merged commit 03fe33e into alibaba:1.8 Feb 20, 2024
8 checks passed
@robberphex robberphex mentioned this pull request Feb 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panxiaojun233 panxiaojun233 panxiaojun233 approved these changes

@LearningGp LearningGp LearningGp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robberphex @LearningGp @panxiaojun233