Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentinel-spring-webmvc-v6x-adapter #3355

Open
wants to merge 11 commits into
base: 1.8
Choose a base branch
from

Conversation

robberphex
Copy link
Collaborator

@robberphex robberphex commented Mar 1, 2024

Describe what this PR does / why we need it

  • update sentinel-spring-webmvc-v6x-adapter
  • add module sentinel-dynamic-setting-extension, sentinel-webflow-extension.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 60.52009% with 167 lines in your changes missing coverage. Please review.

Project coverage is 46.40%. Comparing base (5a7a310) to head (00a1e4b).
Report is 14 commits behind head on 1.8.

Files with missing lines Patch % Lines
.../csp/sentinel/webflow/rule/WebFlowRuleManager.java 57.14% 41 Missing and 16 partials ⚠️
...alibaba/csp/sentinel/webflow/rule/WebFlowRule.java 61.11% 25 Missing and 3 partials ⚠️
...sentinel/slots/block/flow/param/ParamFlowRule.java 25.00% 16 Missing and 2 partials ⚠️
...sp/sentinel/webflow/rule/WebFlowRuleConverter.java 62.50% 13 Missing and 5 partials ⚠️
...aba/csp/sentinel/webflow/param/WebParamParser.java 0.00% 14 Missing ⚠️
...webmvc_v6x/param/HttpServletRequestItemParser.java 62.06% 7 Missing and 4 partials ⚠️
...mvc_v6x/callback/DefaultBlockExceptionHandler.java 78.57% 2 Missing and 7 partials ⚠️
...inel/slots/block/flow/param/ParamFlowRuleUtil.java 37.50% 0 Missing and 5 partials ⚠️
...spring/webmvc_v6x/AbstractSentinelInterceptor.java 63.63% 2 Missing and 2 partials ⚠️
...ba/csp/sentinel/webflow/param/ParamRegexCache.java 85.71% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                1.8    #3355      +/-   ##
============================================
+ Coverage     45.86%   46.40%   +0.54%     
- Complexity     2141     2223      +82     
============================================
  Files           430      438       +8     
  Lines         12900    13305     +405     
  Branches       1730     1799      +69     
============================================
+ Hits           5916     6174     +258     
- Misses         6287     6393     +106     
- Partials        697      738      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants