Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect comment in NodeSelectorSlot javadoc #419

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

kexianjun
Copy link
Contributor

Describe what this PR does / why we need it

correct comment error

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #419 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #419      +/-   ##
============================================
- Coverage     37.74%   37.73%   -0.02%     
+ Complexity      983      982       -1     
============================================
  Files           235      235              
  Lines          7407     7407              
  Branches       1014     1014              
============================================
- Hits           2796     2795       -1     
  Misses         4253     4253              
- Partials        358      359       +1
Impacted Files Coverage Δ Complexity Δ
.../sentinel/slots/nodeselector/NodeSelectorSlot.java 94.73% <ø> (ø) 4 <0> (ø) ⬇️
...a/com/alibaba/csp/sentinel/node/StatisticNode.java 65.57% <0%> (-1.64%) 21% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47148ac...1b394df. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 9697c06 into alibaba:master Jan 15, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 15, 2019

Thanks!

@sczyh30 sczyh30 added the typo-or-format Typo fix or reformat label Jan 15, 2019
@sczyh30 sczyh30 changed the title correct comment error Fix incorrect comment in NodeSelectorSlot javadoc Jan 15, 2019
@kexianjun kexianjun deleted the correct_comment_error branch January 15, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo-or-format Typo fix or reformat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants