Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When click the first-level menu, don't jump to the home page #422

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

cdfive
Copy link
Collaborator

@cdfive cdfive commented Jan 15, 2019

Describe what this PR does / why we need it

Make the sidebar menu more convenient to use.

Does this pull request fix one issue?

Fixes #421

Describe how you did it

Change the <a href="#"> to <a href="javascript:void(0);">

Describe how to verify it

Click one menu then click the first-level menu, the page will not jumped.

Special notes for reviews

@sczyh30 sczyh30 added the to-review To review label Jan 15, 2019
@sczyh30 sczyh30 added this to the 1.4.2 milestone Jan 15, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 303ae86 into alibaba:master Jan 15, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 15, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on the first-level menu will jump to the home page in dashboard
2 participants