Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default argusedtokens #460

Merged
merged 3 commits into from
Feb 22, 2019

Conversation

mjaow
Copy link
Contributor

@mjaow mjaow commented Jan 26, 2019

Describe what this PR does / why we need it

fix default value (-1 -> 0) of arg_used_tokens

Does this pull request fix one issue?

Fixes #459

Describe how you did it

fix default value -1 to 0

Describe how to verify it

CI

Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #460 into master will increase coverage by 3.12%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #460      +/-   ##
============================================
+ Coverage     37.66%   40.79%   +3.12%     
- Complexity      983     1097     +114     
============================================
  Files           235      236       +1     
  Lines          7429     7570     +141     
  Branches       1017     1050      +33     
============================================
+ Hits           2798     3088     +290     
+ Misses         4271     4083     -188     
- Partials        360      399      +39
Impacted Files Coverage Δ Complexity Δ
...slots/block/flow/controller/DefaultController.java 62.5% <50%> (ø) 6 <0> (ø) ⬇️
...nel/slots/block/flow/param/ParamFlowException.java 42.85% <0%> (-19.65%) 3% <0%> (ø)
...inel/slots/block/authority/AuthorityException.java 30% <0%> (-12.86%) 2% <0%> (ø)
...sp/sentinel/slots/system/SystemBlockException.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...inel/cluster/flow/rule/ClusterFlowRuleManager.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...tinel/init/ParamFlowStatisticSlotCallbackInit.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/com/alibaba/csp/sentinel/util/PidUtil.java 100% <0%> (ø) 1% <0%> (ø) ⬇️
...sentinel/slots/block/degrade/DegradeException.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ots/statistic/ParamFlowStatisticEntryCallback.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...lots/statistic/ParamFlowStatisticExitCallback.java 0% <0%> (ø) 0% <0%> (?)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30907e4...748942b. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Jan 26, 2019
@mjaow
Copy link
Contributor Author

mjaow commented Jan 31, 2019

fix is done

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 291742c into alibaba:master Feb 22, 2019
@sczyh30
Copy link
Member

sczyh30 commented Feb 22, 2019

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doubt about default value of avgUsedTokens
3 participants