Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove G2 lib tracking in frontend of Sentinel dashboard #527

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

MickMo
Copy link
Contributor

@MickMo MickMo commented Feb 28, 2019

Fixed #522
Fixed Dashboard try to access Alipay domain https://kcart.alipay.com/web/bi.do?
By upgrading G2 Lib to version 3.4.10

#522

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #527 into master will increase coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #527     +/-   ##
===========================================
+ Coverage     37.68%   38.18%   +0.5%     
- Complexity     1101     1113     +12     
===========================================
  Files           259      259             
  Lines          8173     8173             
  Branches       1113     1113             
===========================================
+ Hits           3080     3121     +41     
+ Misses         4694     4643     -51     
- Partials        399      409     +10
Impacted Files Coverage Δ Complexity Δ
...l/cluster/server/connection/ConnectionManager.java 76% <0%> (+2%) 11% <0%> (+1%) ⬆️
...a/csp/sentinel/slots/statistic/base/LongAdder.java 31.91% <0%> (+14.89%) 10% <0%> (+6%) ⬆️
...a/csp/sentinel/slots/statistic/base/Striped64.java 60.41% <0%> (+34.37%) 10% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec0883d...ade417f. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Feb 28, 2019
@sczyh30
Copy link
Member

sczyh30 commented Feb 28, 2019

Hi, could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=527

@sczyh30 sczyh30 changed the title Fixed Dashboard try to access Alipay domain `https://kcart.alipay.com… Remove G2 lib tracking in frontend of Sentinel dashboard Feb 28, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 3e4fc7a into alibaba:master Mar 1, 2019
@sczyh30
Copy link
Member

sczyh30 commented Mar 1, 2019

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants