-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apollo flow rule publisher sample in Sentinel dashboard #535
Conversation
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
============================================
+ Coverage 37.69% 38.24% +0.55%
- Complexity 1102 1116 +14
============================================
Files 259 259
Lines 8174 8174
Branches 1113 1113
============================================
+ Hits 3081 3126 +45
+ Misses 4695 4642 -53
- Partials 398 406 +8
Continue to review full report at Codecov.
|
...dashboard/src/test/java/com/alibaba/csp/sentinel/dashboard/rule/apollo/ApolloConfigUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing! |
Describe what this PR does / why we need it
sentinel-dashboard 项目Test目录下新增数据源固化到Apollo实现
Does this pull request fix one issue?
Describe how you did it
通过官方的apollo-openapi实现数据源存取
Describe how to verify it
把sentinel-dashboard 项目Test目录下Apollo相关代码加载到项目中,然后在FlowControllerV2.java中修改
如下代码后,运行即可,此代码在实际项目中已运行
Special notes for reviews
因为用到了Apollo的OpenAPI,所以引用了apollo-openapi这个包来实现