Refactor and improve Sentinel Zuul Adapter #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now the adapter is based-on sentinel-api-gateway-adapter-common and supports both proxyId and customized APIs Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
sczyh30
added
to-review
|
@tigerMoon Hi, I've refactored the Zuul adapter to support more scenarios for gateway flow control. Would you like to give some suggestions? You can refer to the document here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Refactor and improve Sentinel Zuul Adapter based on
sentinel-api-gateway-adapter-common, so that it can support (normal and parameter) flow control of both route level and customized API level.Does this pull request fix one issue?
NONE
Describe how you did it
The refactored
SentinelZuulPreFilterwill regard all route ID (proxyinRequestContext) and all customized API (retrieved fromsentinel-api-gateway-adapter-commonmodule) as resources. The pre-filter may create multiple resource entries, so to pass to theSentinelZuulPostFilter, we'll collect all created entries and put into a stack (based onArrayDeque), then carry it into theRequestContext. Then when the request is completed,SentinelZuulPostFiltercan get the entries from Zuul context and exit them in descending order.A demo is added to show how to use the adapter.
Describe how to verify it
Run the test cases and demo.
Special notes for reviews
This PR contains breaking changes. Please take care of the changes.