-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bug of getting wrong cluster flow QPS in ClusterFlowChecker #972
Conversation
changxing.yu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
============================================
+ Coverage 42.61% 42.63% +0.02%
Complexity 1443 1443
============================================
Files 310 310
Lines 8985 8985
Branches 1222 1222
============================================
+ Hits 3829 3831 +2
+ Misses 4691 4689 -2
Partials 465 465
Continue to review full report at Codecov.
|
Hi, thanks for contributing. Could you please sign the CLA here? And please make sure the email of your commits match your GitHub email. 感谢贡献,请将 commit 对应的 email 调整成与 GitHub 的 email 相匹配并 确认一下 CLA。 |
Friendly ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[RIP-9] format readme, delete useless spaces symbol
Describe what this PR does / why we need it
Fix the bug when getting current cluster flow QPS in
ClusterFlowChecker
.The QPS should be calculated with
PASS
rather thanPASS_REQUEST
. ThePASS_REQUEST
will ignore theacquireCount
.Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews