Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix attach doublecheck #2399

Merged
merged 1 commit into from
Jan 12, 2023
Merged

fix attach doublecheck #2399

merged 1 commit into from
Jan 12, 2023

Conversation

JoeCqupt
Copy link
Contributor 

telnetPortPid = findProcessByTelnetClient(arthasHomeDir.getAbsolutePath(),

method findProcessByTelnetClient may find telnetPortPid , we should check telnetPortPid == pid again.

@JoeCqupt
Copy link
Contributor Author

@hengyunabc PTAL

hengyunabc
hengyunabc reviewed Jan 12, 2023
View reviewed changes
boot/src/main/java/com/taobao/arthas/boot/Bootstrap.java
attachArgs.add("-target-ip");
attachArgs.add(bootstrap.getTargetIp());
}
// start arthas-core.jar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么增加了缩进？好像原来的缩进是没问题的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为新增了else代码块

@hengyunabc hengyunabc added this to the 3.6.8 milestone Jan 12, 2023
@hengyunabc hengyunabc merged commit cbf6845 into alibaba:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengyunabc hengyunabc hengyunabc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.8
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeCqupt @hengyunabc