Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http header connection close #2432

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Add http header connection close #2432

merged 2 commits into from
Apr 18, 2023

Conversation

Joey777210
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

hengyunabc
hengyunabc reviewed Feb 17, 2023
View reviewed changes
core/src/main/java/com/taobao/arthas/core/shell/term/impl/http/HttpRequestHandler.java Outdated
@@ -122,6 +122,7 @@ public void operationComplete(ChannelFuture future) throws Exception {
}

private ChannelFuture writeResponse(ChannelHandlerContext ctx, HttpResponse response) {
response.headers().set(HttpHeaderNames.CONNECTION, HttpHeaderValues.CLOSE);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接加在这里好像有问题，大文件下载可能会被提早close掉了。

@Joey777210
Copy link
Contributor Author

修改了添加header的代码位置。（请问哪种case下会有大文件下载呢？

@Joey777210
Copy link
Contributor Author

测试了http访问localhost:8563/arthas-output下的大文件下载，目前没有出现提前close的情况

@hengyunabc hengyunabc added this to the 3.6.8 milestone Mar 13, 2023
@hengyunabc hengyunabc merged commit 8024aca into alibaba:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengyunabc hengyunabc hengyunabc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Joey777210 @CLAassistant @hengyunabc