Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize connectTimeout and socketTimeout from jdbcUrl or properties #5706

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Jan 24, 2024

see #5310 #5565

@zrlw zrlw changed the title synchronize connectTimeout and socketTimeout value at setConnectionProperties initialize connectTimeout and socketTimeout from jdbcUrl or properties Jan 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 21 lines in your changes missing coverage. Please review.

Project coverage is 58.72%. Comparing base (0884b37) to head (c06c8f4).
Report is 342 commits behind head on master.

Files with missing lines Patch % Lines
...om/alibaba/druid/pool/DruidAbstractDataSource.java 29.16% 13 Missing and 4 partials ⚠️
...n/java/com/alibaba/druid/pool/DruidDataSource.java 80.95% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5706      +/-   ##
============================================
- Coverage     58.73%   58.72%   -0.01%     
+ Complexity    27789    27782       -7     
============================================
  Files          1333     1333              
  Lines        127668   127681      +13     
  Branches      24052    24058       +6     
============================================
- Hits          74982    74979       -3     
- Misses        43354    43366      +12     
- Partials       9332     9336       +4     
Files with missing lines Coverage Δ
...n/java/com/alibaba/druid/pool/DruidDataSource.java 70.19% <80.95%> (-0.20%) ⬇️
...om/alibaba/druid/pool/DruidAbstractDataSource.java 78.84% <29.16%> (-0.69%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0884b37...c06c8f4. Read the comment docs.

@wenshao wenshao merged commit 21b55b4 into alibaba:master Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants