Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct parsing errors in ProcessorParseApsaraNative with large buffer input #1255

Merged
merged 12 commits into from
Dec 7, 2023

Conversation

quzard
Copy link
Collaborator

@quzard quzard commented Dec 4, 2023

This commit addresses incorrect parsing outcomes in ProcessorParseApsaraNative when reading a large buffer that contains multiple log entries. New unit tests have been introduced for ProcessorParseApsaraNative, ProcessorParseDelimiterNative, and ProcessorParseJsonNative to verify accurate parsing of log data in scenarios involving large buffer inputs.

@quzard
Copy link
Collaborator Author

quzard commented Dec 4, 2023

增加ProcessorParseApsaraNative、ProcessorParseDelimiterNative、ProcessorParseJsonNative三个插件的多行情况下的单测

@quzard
Copy link
Collaborator Author

quzard commented Dec 4, 2023

修复ProcessorParseApsaraNative插件在多行情况下的异常

core/processor/ProcessorParseApsaraNative.cpp Outdated Show resolved Hide resolved
core/processor/ProcessorParseApsaraNative.cpp Outdated Show resolved Hide resolved
core/processor/ProcessorParseApsaraNative.cpp Outdated Show resolved Hide resolved
core/processor/ProcessorParseApsaraNative.cpp Outdated Show resolved Hide resolved
core/processor/ProcessorParseApsaraNative.cpp Outdated Show resolved Hide resolved
core/processor/ProcessorParseApsaraNative.cpp Outdated Show resolved Hide resolved
core/processor/ProcessorParseApsaraNative.cpp Outdated Show resolved Hide resolved
@yyuuttaaoo yyuuttaaoo added this to the v1.8 milestone Dec 6, 2023
@yyuuttaaoo yyuuttaaoo added the bug Something isn't working label Dec 6, 2023
@yyuuttaaoo yyuuttaaoo changed the title add processorNative MultipleLines test fix: Correct parsing errors in ProcessorParseApsaraNative with large buffer input Dec 7, 2023
@yyuuttaaoo yyuuttaaoo merged commit ff0d88d into alibaba:main Dec 7, 2023
20 checks passed
yyuuttaaoo pushed a commit that referenced this pull request Dec 7, 2023
quzard added a commit to quzard/ilogtail that referenced this pull request Dec 8, 2023
…buffer input (alibaba#1255)

* fix 越界问题

* add comment

(cherry picked from commit ff0d88d)
henryzhx8 pushed a commit that referenced this pull request Dec 8, 2023
* fix: Correct parsing errors in ProcessorParseApsaraNative with large buffer input (#1255)
---------

Co-authored-by: yitao <[email protected]>
yyuuttaaoo pushed a commit that referenced this pull request Dec 24, 2023
* complete pipeline definition (#1185)

* add common param extractor

* add input_file

* add input_observer_network

* add flusher_SLS

* add global config module

* improve pipeline def

* polish code

* polish code

* add pipeline implementation

* polish code

* seperate params from input_file

* polish code

* polish code

* add file server

* polish code

* polish code

* polish code

* fix bug

* polish code

* fix bug

* polish code

* refactor code

* refactor event dispatcher

* remove global filter

* refactor app config

* remove shennong and streamlog

* fix bug

* upgrade V1 config to V2

* fix bug

* refactor pipeline management

* add ut

* add ut

* fix e2e

* polish code

* for tmp use

* for tmp use

* polish code

* for tmp use

* for tmp use

* fix

* fix e2e

* temporarily remove observer case

* fix e2e

* fix e2e

* polish code

* Yaml (#3)

* ParseYamlConfig

* polish code

* fix e2e

* remove old config

* cleanup gflags

* fix bug

* polish code

* polish code

* polish code

* fix bug

* polish code

* polish code

* fix code

* polish code

* polish

* fix code

* fix

* fix

* polish code

* fix

* fix

* fix

* polish

* polish

* polish code

* test

* test

* polish

* fix observer

* polish test

* fix code

* polish code

* polish code

* fix bug

* Pipeline processor (#2)

upgrade processor to v2

* polish code

* polish

* polish

* polish code

* polish code

* In order to achieve a relatively unified interface for SPL and other plugins, the interface definition has been optimized. (#1254)

* refine interface

* refine code

* refine code

* refine code

* fix comments

* polish code

* polish

* polish

* polish code

* polish

* fix code

* fix

* fix

* polish code

* add log

* fix

* fix bug

* fix

* fix bug

* polish

* fix

* fix

* fix

* fix

* fix

* fix

* Merge processor changes of main branches (#1259)

* fix: Correct parsing errors in ProcessorParseApsaraNative with large buffer input (#1255)
---------

Co-authored-by: yitao <[email protected]>

* polish

* add alarm

* polish

* polish

* polish

* polish code

* polish

* polish code

* polish

---------

Co-authored-by: quzard <[email protected]>
Co-authored-by: linrunqi08 <[email protected]>
Co-authored-by: yitao <[email protected]>
Co-authored-by: 笃敏 <[email protected]>
@quzard quzard deleted the add-processor-test branch February 28, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants