Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve crash by setting CURLOPT_NOSIGNAL for thread safety #1283

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

yyuuttaaoo
Copy link
Collaborator

No description provided.

@@ -501,6 +501,7 @@ ECSMeta FetchECSMeta() {
std::string meta;
curl_easy_setopt(curl, CURLOPT_URL, "http://100.100.100.200/latest/dynamic/instance-identity/document");
curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);
curl_easy_setopt(curl, CURLOPT_NOSIGNAL, 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

趁热写篇文章出来

@yyuuttaaoo yyuuttaaoo merged commit c88668c into alibaba:main Dec 27, 2023
17 checks passed
@yyuuttaaoo yyuuttaaoo added this to the v2.0 milestone Jan 2, 2024
@yyuuttaaoo yyuuttaaoo added the bug Something isn't working label Jan 11, 2024
@yyuuttaaoo yyuuttaaoo deleted the fix/curl branch April 7, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants