[backport]Fix timestamp parsing compatibility issue for apsara log #1285 #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a compatibility issue with timestamp parsing in apsara logs by ilogtail. Previously, ilogtail enforced a strict time format of %Y-%m-%d %H:%M:%S.%f, which resulted in failures when encountering apsara logs formatted with %Y-%m-%d %H:%M:%S,%f. The fix introduces a more flexible parsing logic that disregards the character immediately following %S, allowing the parser to correctly handle sub-second parts denoted by any character. This patch also ensures that ilogtail can successfully parse timestamps without failing when the sub-second part is absent.
messixukejia
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a compatibility issue with timestamp parsing in apsara logs by ilogtail. Previously, ilogtail enforced a strict time format of %Y-%m-%d %H:%M:%S.%f, which resulted in failures when encountering apsara logs formatted with %Y-%m-%d %H:%M:%S,%f.
The fix introduces a more flexible parsing logic that disregards the character immediately following %S, allowing the parser to correctly handle sub-second parts denoted by any character. This patch also ensures that ilogtail can successfully parse timestamps without failing when the sub-second part is absent.