Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait for read flush timeout instead of flushing last line immediately on file deletion #1418

Merged
merged 4 commits into from
Mar 29, 2024
Merged

wait for read flush timeout instead of flushing last line immediately on file deletion #1418

merged 4 commits into from
Mar 29, 2024

Conversation

henryzhx8
Copy link
Collaborator

@henryzhx8 henryzhx8 commented Mar 26, 2024 •
edited
Loading

  • 问题：
    reader队列只有一个reader的时候，如果delete flag为true且已经读到尾巴了，会强制将最后不完整的日志发送出去。因为delete flag只是个hint，所以可能导致日志被截断。
  • 修复：
    对于上述情况，等待超时事件发生才flush。

@henryzhx8 henryzhx8 marked this pull request as ready for review March 27, 2024 13:24
@yyuuttaaoo yyuuttaaoo merged commit 3d546a7 into main Mar 29, 2024
15 checks passed
@yyuuttaaoo yyuuttaaoo added this to the v2.0 milestone Mar 29, 2024
@henryzhx8 henryzhx8 deleted the fix/delete branch April 2, 2024 09:13
@henryzhx8 henryzhx8 added the bug Something isn't working label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyuuttaaoo yyuuttaaoo yyuuttaaoo approved these changes

@messixukejia messixukejia Awaiting requested review from messixukejia

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@henryzhx8 @yyuuttaaoo