Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactory: enable move for SourceBuffer #1457

Merged
merged 4 commits into from
Apr 23, 2024
Merged

refactory: enable move for SourceBuffer #1457

merged 4 commits into from
Apr 23, 2024

Conversation

henryzhx8
Copy link
Collaborator

  1. 允许SourceBuffer被移动
  2. 调整SourceBuffer.h文件位置
  3. LogBuffer与SourceBuffer的关系从继承改成组合，主要便于组装PipelineEventGroup（只需要SourceBuffer，不需要LogBuffer）

yyuuttaaoo
yyuuttaaoo requested changes Apr 22, 2024
View reviewed changes
core/reader/LogFileReader.h Outdated Show resolved Hide resolved
@yyuuttaaoo yyuuttaaoo added the miscellaneous Code format, comment and etc. label Apr 23, 2024
@yyuuttaaoo yyuuttaaoo changed the title enable move for SourceBuffer refactory: enable move for SourceBuffer Apr 23, 2024
@yyuuttaaoo yyuuttaaoo added this to the v2.1 milestone Apr 23, 2024
@yyuuttaaoo yyuuttaaoo added enhancement Feature enhancement and removed miscellaneous Code format, comment and etc. labels Apr 23, 2024
@yyuuttaaoo yyuuttaaoo merged commit 196de0d into main Apr 23, 2024
15 checks passed
@yyuuttaaoo yyuuttaaoo deleted the mem branch April 23, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linrunqi08 linrunqi08 linrunqi08 approved these changes

@messixukejia messixukejia messixukejia approved these changes

@yyuuttaaoo yyuuttaaoo yyuuttaaoo approved these changes

Assignees
No one assigned
Labels
enhancement Feature enhancement
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@henryzhx8 @yyuuttaaoo @messixukejia @linrunqi08