feat(metrics): helm add additionalLabels #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyt99
requested changes
May 14, 2024
|
Hi, thanks for your contribution! It looks good to me, and it could be better if you provide examples for this configuration in |
halleystar
force-pushed
the
feature/helm-additionalLabels
branch
from
5c0762c
to
f164800
Compare
|
I've added an example in values.yaml |
halleystar
force-pushed
the
feature/helm-additionalLabels
branch
from
f164800
to
263656b
Compare
feat(metrics): add some examples for additionalLabels in values.yaml feat(metrics): add some examples for additionalLabels in values.yaml feat(metrics): add some examples for additionalLabels in values.yaml file(in comments)
halleystar
force-pushed
the
feature/helm-additionalLabels
branch
from
263656b
to
2544cfd
Compare
Lyt99
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.