ExceptionHandler 中 Exception 部分返回 body 参数增加 html 转义 #10643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
requested changes
Jun 19, 2023
| @ExceptionHandler(IllegalArgumentException.class) | ||
| private ResponseEntity<String> handleIllegalArgumentException(IllegalArgumentException e) { | ||
| return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(ExceptionUtil.getAllExceptionMsg(e)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please don't change the indent. Use nacos code style to reformat codes.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #10643 +/- ##
==========================================
Coverage 53.60% 53.60%
- Complexity 5516 5517 +1
==========================================
Files 897 897
Lines 28811 28812 +1
Branches 3161 3161
==========================================
+ Hits 15444 15445 +1
- Misses 12018 12019 +1
+ Partials 1349 1348 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
KomachiSion
reviewed
Jun 26, 2023
| } | ||
| return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(ExceptionUtil.getAllExceptionMsg(e)); | ||
| return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR) | ||
| .body(HtmlUtils.htmlEscape(ExceptionUtil.getAllExceptionMsg(e), "utf-8")); |
There was a problem hiding this comment.
Why directly set utf-8？
|
这里是提供给 HtmlUtils.htmlEscape 方法使用的，如果不设置的话默认是 iso-8859-1，会导致西文之外的字符集乱码 |
KomachiSion
approved these changes
Jun 30, 2023
wukong121
pushed a commit
to wukong121/nacos
that referenced
this pull request
Aug 4, 2023
* ExceptionHandler 中 Exception 部分返回 body 参数增加 html 转义 * 根据 nacos code style 重新格式化该文件
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relation #10640
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
在 ExceptionHandler 中，返回的数据如果存在 html 标签，则可能导致前端出现一些特殊情况，所以对于未知的 Exception 返回 body 部分增加 html 转义
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.