Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nacos ci #10666

Merged
merged 1 commit into from
Jun 21, 2023
Merged

add nacos ci #10666

merged 1 commit into from
Jun 21, 2023

Conversation

Wuyunfan-BUPT
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

add nacos ci.

Brief changelog

add pr-ci.yml, pr-e2e-test.yml, push-ci.yml to support nacos ci.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #10666 (b755d60) into develop (f40e593) will increase coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10666      +/-   ##
=============================================
+ Coverage      53.58%   53.70%   +0.12%     
- Complexity      5516     5518       +2     
=============================================
  Files            897      897              
  Lines          28811    28811              
  Branches        3161     3161              
=============================================
+ Hits           15437    15473      +36     
+ Misses         12025    11991      -34     
+ Partials        1349     1347       -2     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40e593...b755d60. Read the comment docs.

@KomachiSion KomachiSion merged commit ecd8ed8 into alibaba:develop Jun 21, 2023
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants