-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #12466] serviceMetadata environment variables config #12477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -28,28 +30,32 @@ | |||
* @author zhuoguang | |||
*/ | |||
public class DefaultParamChecker extends AbstractParamChecker { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要修改缩进, 请使用nacos code style进行格式化
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的老师,晚点我修改下,这个没注意。~
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12477 +/- ##
=============================================
+ Coverage 69.28% 69.36% +0.07%
- Complexity 9405 9422 +17
=============================================
Files 1281 1281
Lines 41482 41484 +2
Branches 4387 4387
=============================================
+ Hits 28741 28774 +33
+ Misses 10668 10639 -29
+ Partials 2073 2071 -2
... and 31 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
resolves #12466
增加serviceMetadata的环境变量配置: NACOS_NAMING_SERVICE_METADATA_LENGTH
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.