Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12466] serviceMetadata environment variables config #12477

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

fuhouyu
Copy link
Contributor

@fuhouyu fuhouyu commented Aug 8, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

resolves #12466
增加serviceMetadata的环境变量配置: NACOS_NAMING_SERVICE_METADATA_LENGTH

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -28,28 +30,32 @@
* @author zhuoguang
*/
public class DefaultParamChecker extends AbstractParamChecker {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要修改缩进, 请使用nacos code style进行格式化

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的老师,晚点我修改下,这个没注意。~

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.36%. Comparing base (3967c91) to head (51ef382).
Report is 3 commits behind head on develop.

Files Patch % Lines
.../plugin/auth/impl/jwt/NacosSignatureAlgorithm.java 0.00% 3 Missing ⚠️
...a/nacos/common/paramcheck/DefaultParamChecker.java 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12477      +/-   ##
=============================================
+ Coverage      69.28%   69.36%   +0.07%     
- Complexity      9405     9422      +17     
=============================================
  Files           1281     1281              
  Lines          41482    41484       +2     
  Branches        4387     4387              
=============================================
+ Hits           28741    28774      +33     
+ Misses         10668    10639      -29     
+ Partials        2073     2071       -2     
Files Coverage Δ
...a/nacos/common/paramcheck/DefaultParamChecker.java 99.06% <91.66%> (ø)
.../plugin/auth/impl/jwt/NacosSignatureAlgorithm.java 67.60% <0.00%> (-1.96%) ⬇️

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3967c91...51ef382. Read the comment docs.

@KomachiSion KomachiSion merged commit c56c415 into alibaba:develop Aug 12, 2024
7 checks passed
@KomachiSion KomachiSion added this to the 2.4.1 milestone Aug 12, 2024
@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nacos对于Service Metadata大小的限制问题
3 participants