[ISSUE #12017] Add console backend unit tests and fix bugs #12622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add history handling module
* Add service handling module * Add instance handling module
* Add user handling module * Add role handling module * Add permission handling module
* Add cluster handling module
* Fix the error by adding ApiType
…oller * Refactor the old version of the console's controller
…ction" This reverts commit 052112a.
* Updated ControllerV3 for auth section
* Add ApiType annotation * Transfer the updateCluster method * Fix Compilation Errors
…o develop-issue#12017-api-test
* Add unit tests for all sections
* Add getAllSubClientConfigByIp method in config section * Fix bugs in AuthFilter and RemoteRequestAuthFilter * Fix bugs in ServiceProxy
* Add language validate
…to develop-issue#12017-api-test
* Add validation operations
* Fix namespace update method
* Add config error codes
KomachiSion
requested changes
Sep 18, 2024
| /** | ||
| * Conflict error. | ||
| */ | ||
| CONFLICT(409, "Conflict"), |
| @@ -64,6 +66,11 @@ public Result<Map<String, String>> serverState() { | |||
| @GetMapping("/announcement") | |||
| public Result<String> getAnnouncement( | |||
| @RequestParam(required = false, name = "language", defaultValue = "zh-CN") String language) { | |||
| // Validate the language parameter | |||
| List<String> supportedLanguages = Arrays.asList("zh-CN", "en-US"); | |||
| * Get subscribe information from client side. | ||
| */ | ||
| @GetMapping("/listener/ip") | ||
| @Secured(resource = Constants.LISTENER_CONTROLLER_PATH, action = ActionTypes.READ, signType = SignType.CONFIG) |
| @@ -227,6 +229,7 @@ public Object getServiceList(@RequestParam(required = false) boolean withInstanc | |||
| @GetMapping() | |||
| public Object getServiceDetail(@RequestParam(defaultValue = Constants.DEFAULT_NAMESPACE_ID) String namespaceId, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
For 12017
Add console backend unit tests and fix bugs
Brief changelog
Add unit tests for all sections
Add getAllSubClientConfigByIp method in config section
Fix bugs in AuthFilter and RemoteRequestAuthFilter
Fix bugs in ServiceProxy
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.