-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #12625] FIX tenant_capacity query SQL dialect #12628
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12628 +/- ##
==========================================
Coverage 69.70% 69.70%
- Complexity 9431 9434 +3
==========================================
Files 1275 1275
Lines 41232 41234 +2
Branches 4374 4374
==========================================
+ Hits 28740 28743 +3
- Misses 10412 10413 +1
+ Partials 2080 2078 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
看了你新提交的代码,要考虑如下问题: 有必要使用并行stream吗? |
感谢老师的review,没有考虑并行流的场景在这里并不合适。 然后我看了一下SELECT的影响范围,这个方法的父类只会是使用在SELECT 查询上面。 子类只是额外处理了这个columns,并没有操作where,对于整个查询是没有影响的。 或者是将这个方法挪到子类,这样就会减少一次循环处理,不知道这样是不是更好一点。
|
有其它更好的解决方案PR |
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
resolves #12625 #12598
FIX tenant_capacity query SQL dialect
修复租户查询的SQL方言问题,在TrustedlFunctionEnum 中添加转义的字符返回,以便sql在出现关键字时的后续处理。
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.