Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log for server list manager and split constructor and start. #12736

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

For #12189

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.94%. Comparing base (66feeec) to head (608ad7a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...acos/client/address/AbstractServerListManager.java 77.77% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12736      +/-   ##
=============================================
- Coverage      70.95%   70.94%   -0.02%     
- Complexity      9614     9623       +9     
=============================================
  Files           1275     1278       +3     
  Lines          41260    41206      -54     
  Branches        4375     4360      -15     
=============================================
- Hits           29277    29232      -45     
+ Misses          9894     9880      -14     
- Partials        2089     2094       +5     
Files with missing lines Coverage Δ
...os/client/config/impl/ConfigServerListManager.java 72.46% <100.00%> (ø)
...acos/client/naming/NacosNamingMaintainService.java 100.00% <100.00%> (ø)
...os/client/naming/core/NamingServerListManager.java 76.00% <100.00%> (ø)
...lient/naming/remote/NamingClientProxyDelegate.java 95.52% <100.00%> (+0.06%) ⬆️
...acos/client/address/AbstractServerListManager.java 79.54% <77.77%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b971164...608ad7a. Read the comment docs.

@KomachiSion KomachiSion merged commit c6b088c into alibaba:develop Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants