Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cameraInit] Support more extensions and add new viewId generation method #823

Merged
merged 5 commits into from
Jun 30, 2020
Merged

[cameraInit] Support more extensions and add new viewId generation method #823

merged 5 commits into from
Jun 30, 2020

Conversation

dsmtE
Copy link
Contributor

@dsmtE dsmtE commented Jun 25, 2020 •
edited
Loading

Features list

  • Support more extensions, using available extensions with OpenImageIO ([multiview] declare more recognized image file extensions Meshroom#965)
  • Add a method to define viewId from filename (via regex) instead of generating a UID from metadata to enable evaluation tests on datasets with ground truth.
  • Allow to choose the intrinsics permitted in the init camera

@dsmtE dsmtE added the feature label Jun 25, 2020
@dsmtE dsmtE marked this pull request as draft June 25, 2020 17:26
@dsmtE dsmtE added the wip work in progress label Jun 25, 2020
@dsmtE dsmtE mentioned this pull request Jun 25, 2020
Merged
@dsmtE dsmtE force-pushed the dev/improveCameraInit branch 2 times, most recently from 4afc63d to 7d4d4f8 Compare June 30, 2020 15:15
@dsmtE
[software] camerainit: viewId from filename
7e60033 
Add a method to define viewId from filename
@dsmtE dsmtE marked this pull request as ready for review June 30, 2020 18:46
@fabiencastan fabiencastan added this to the 2020.1.0 milestone Jun 30, 2020
@dsmtE dsmtE mentioned this pull request Jun 30, 2020
Merged
2 tasks
@fabiencastan fabiencastan removed the wip work in progress label Jun 30, 2020
@fabiencastan fabiencastan merged commit f754e45 into develop Jun 30, 2020
@fabiencastan fabiencastan deleted the dev/improveCameraInit branch June 30, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dsmtE @fabiencastan