[ui] NodeLog: load file only if visible

* when visibility changes, only load current file if log is actually visible * set 'keepCursorPosition' default value to false in 'loadCurrentFile' method
alicevision · Sep 6, 2018 · 3b656d9 · 3b656d9
1 parent 143b519
commit 3b656d9
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/meshroom/ui/qml/GraphEditor/NodeLog.qml b/meshroom/ui/qml/GraphEditor/NodeLog.qml
@@ -87,8 +87,9 @@ FocusScope {
                 property string currentFile: chunksLV.currentChunk ? chunksLV.currentChunk[currentItem.fileProperty] : ""
                 property string lastLoadedFile
                 property date lastModTime
-                onCurrentFileChanged: if(visible) loadCurrentFile(false)
-                onVisibleChanged: loadCurrentFile()
+                onCurrentFileChanged: if(visible) loadCurrentFile()
+                onVisibleChanged: if(visible) loadCurrentFile()
+
 
                 TabButton {
                     property string fileProperty: "logFile"
@@ -197,6 +198,8 @@ FocusScope {
 
     function loadCurrentFile(keepCursorPosition)
     {
+        if(keepCursorPosition == undefined)
+            keepCursorPosition = false
         var xhr = new XMLHttpRequest;
         xhr.open("GET", Filepath.stringToUrl(fileSelector.currentFile));
         xhr.onreadystatechange = function() {