-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New lens distortion calibration node #1403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from fabiencastan
May 3, 2021 10:29
fabiencastan
force-pushed
the
dev/distortionCalibration
branch
from
May 3, 2021 21:53
dce075a
to
ec7f17d
Compare
fcastan
force-pushed
the
dev/distortionCalibration
branch
2 times, most recently
from
May 27, 2021 22:06
aaf5af0
to
7138e3e
Compare
fcastan
force-pushed
the
dev/distortionCalibration
branch
from
May 31, 2021 12:59
7138e3e
to
5b35b9a
Compare
The intrinsics contains pxFocalLength as 2 values (x,y) since 1.2 version.
- DistortionCalibration in input of the FeatureMatching (instead of SfM) - Add sfmDataFilter in input of ExportAnimatedCamera
fabiencastan
changed the title
Dev/distortion calibration
New lens distortion calibration node
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update camerainit node to accept new kind of cameras.
Update camerainit node such that a camera has two focal lengths in pixels (both horizontal and vertical)
Add a distortion calibration node
Based on alicevision/AliceVision#1035