-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nodes] New node "RenderAnimatedCamera" using blender API #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielDelaporus
force-pushed
the
dev/blenderRender
branch
from
June 2, 2021 16:33
6117121
to
76fe403
Compare
@@ -0,0 +1,405 @@ | |||
import bpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename the file to something like "renderAnimatedCameraInBlender.py"
|
||
class RenderAnimatedCamera(desc.CommandLineNode): | ||
commandLine = '{blenderPathValue} -b --python {scriptPathValue} -- {allParams}' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add category and documentation variables.
DanielDelaporus
force-pushed
the
dev/blenderRender
branch
from
July 2, 2021 14:44
76fe403
to
e8c86bc
Compare
…not functional yet)
The node is almost functional. The animated camera works but the imported cloud of point isn't visible is rendering... I'll need to find a way to make display it. (For now there is a cube as a placeholder in the scene to show the movement of the camera)
The returns in ExportAnimatedCamera didn't include the path toward the undistorted images so I added it. The Blender Rendition nodes can now (among other things) diplay cloud of points. The code is cleaned up and only the background image sequence remains to be implemented...
Added a numeral scale to the node to make the density rendering of the cloud of point more customisable...
I had to use the graphe node to render the image in the back. I also made the node much more adaptable. I'll verify if it works with another set of image.
Almost complete version of the node, I added a background that can render with eevee and changed the cubes used as particles by a plane that always follows the camera. The one of the only thing left is the option to change the color of the particle (among other things).
Many minor bug fixes and added the possibility to change the particle color of the rendering to let the user chose the clearest color in their case. Commented a lot of my code to make it readable to someone else that myself.
Added the possibility of rendering the output of the meshing node into a edge detection render of the obj. Added the activation and deactivation of the background images as an option. Improving the way the arguments are shown with a conditionnal display of some arguments.
fabiencastan
force-pushed
the
dev/blenderRender
branch
from
July 23, 2021 14:23
e8c86bc
to
b226c35
Compare
fabiencastan
force-pushed
the
dev/blenderRender
branch
from
July 23, 2021 14:25
b226c35
to
fdf45fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This node uses Blender's API to Display the SFM Data at some specific points in the pipepline using the imported animated camera to show the result.
Before going into details the user need to link the path to their blender.exe file. This is mandatory to use the software.
Features list
The SFM Data extension changes drastically the way it's processed. It changes completely the render options so I added a system that displays the different render features dynamically using the SFM Data Path.
If the Data is a Point Cloud, the user can change the size, the color and the density of the particle used to display in on blender.
If the Data is a Mesh, the user can change the color of the edges of the display on blender.
The feature to display the background image is not mandatory.
Finally the sequence is render in 4 supported format. Gif are not included because that are not supported by blender. However we could imagine it being possible in the future using external converting tools.
Something else that we could add it the possibility to add several render if the imported alembic containing the camera contains several of them.
Implementation remarks
Most of the choices were made so the client could see and compare the result of meshroom to the original data set.
We tried to multiply features so that if the client has choices in their render method.
Every render was made using blender.