[ui] Display computation time for "running" or "finished" nodes #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
reviewed
Sep 5, 2022
fabiencastan
reviewed
Sep 5, 2022
cbentejac
force-pushed
the
dev/displayComputeTime
branch
from
bb492c4
to
fa4a9d6
Compare
fabiencastan
reviewed
Sep 8, 2022
fabiencastan
reviewed
Sep 8, 2022
cbentejac
force-pushed
the
dev/displayComputeTime
branch
3 times, most recently
from
02989a9
to
d2689fb
Compare
cbentejac
force-pushed
the
dev/displayComputeTime
branch
from
d2689fb
to
5542516
Compare
fabiencastan
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR displays, for a node whose status is either "FINISHED" or "RUNNING", the computation time in the title bar of the node. For nodes with several chunks, the displayed time corresponds to the cumulated computation time of every chunk; in that case, the computation time for the longest chunk is also displayed in a tooltip.