Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add cgroups support to meshroom #1836

Merged
merged 9 commits into from
Dec 8, 2022
Merged

[core] Add cgroups support to meshroom #1836

merged 9 commits into from
Dec 8, 2022

Conversation

servantftechnicolor
Copy link
Contributor

@servantftechnicolor servantftechnicolor commented Dec 2, 2022

CGroups on linux may limit the memory and the number of cpus

Without getting the specific information about these limits, we may overshoot our memory usage and core usage, creating crashes.

This PR will read the values as specified by the specifications.

Rely on alicevision/AliceVision#1304.

@fabiencastan
Copy link
Member

We need to find a way for nodes to declare if they supports these arguments or rely on environment variables.
We have many nodes launching external commands (like blender).
We could for instance create an intermediate class for AVCommandLineNode.

@mh0g
Copy link
Contributor

mh0g commented Dec 5, 2022

we could use a chunk.node.nodeDesc.commandLine.startswith("aliceVision_") to do this only on the proper nodes

@mh0g
Copy link
Contributor

mh0g commented Dec 5, 2022

a warning in the log when the feature is used may be usefull

Copy link
Contributor

@mh0g mh0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on windows, no effect (as expected).
Note: the class solution changes the uid of the nodes, this forces to recompute projects.

meshroom/core/desc.py Outdated Show resolved Hide resolved
meshroom/core/desc.py Outdated Show resolved Hide resolved
@fabiencastan fabiencastan added this to the Meshroom 2022.1.0 milestone Dec 8, 2022
@servantftechnicolor servantftechnicolor changed the title Add cgroups support to meshroom [node] Add cgroups support to meshroom Dec 8, 2022
@servantftechnicolor servantftechnicolor changed the title [node] Add cgroups support to meshroom [core] Add cgroups support to meshroom Dec 8, 2022
@fabiencastan fabiencastan merged commit 1b05ccb into develop Dec 8, 2022
@fabiencastan fabiencastan deleted the dev/cgroups branch December 8, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants