Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Load 3D Depth Map: minor improvements #1852

Merged
merged 2 commits into from
Jan 4, 2023
Merged

[ui] Load 3D Depth Map: minor improvements #1852

merged 2 commits into from
Jan 4, 2023

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Dec 20, 2022

Description

This PR introduces some minor improvements around loading depth maps in 3D:

  • the "View Depth Map in 3D" button in the 2D viewer is enabled only when the currently viewed attribute corresponds to a depth map
  • when loading a depth map in the 3D viewer with this button, a custom label is used in the 3D inspector composed of the node name, attribute name and view id.

@mugulmd mugulmd self-assigned this Dec 20, 2022
@fabiencastan fabiencastan added this to the Meshroom 2022.1.0 milestone Dec 22, 2022
fabiencastan
fabiencastan requested changes Dec 22, 2022
View reviewed changes
Copy link
Member

@fabiencastan fabiencastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we double click on the depth map node, it creates an empty entry in the 3D Viewer, and when we click on the "View DepthMap in 3D" button, it creates another entry:
image

@fabiencastan fabiencastan marked this pull request as draft December 22, 2022 23:59
@fabiencastan fabiencastan marked this pull request as ready for review January 3, 2023 11:28
fabiencastan
fabiencastan approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@fabiencastan fabiencastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, it's working fine. Probably just a mistake in my setup during my previous test.

@fabiencastan
Copy link
Member

fabiencastan commented Jan 3, 2023 •
edited
Loading

In fact, the behavior of opening the Node as an empty element in the 3D Viewer occurs when the node is in "Compatibility mode".

@fabiencastan fabiencastan merged commit 27ce3df into develop Jan 4, 2023
@fabiencastan fabiencastan deleted the mug/improveLoadDepthMap3D branch January 4, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

Assignees

@mugulmd mugulmd

Labels
None yet
Projects
None yet
Milestone
Meshroom 2023.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mugulmd @fabiencastan