Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Photometric Stereo nodes #1853

Merged
merged 23 commits into from
Jun 4, 2023
Merged

New Photometric Stereo nodes #1853

merged 23 commits into from
Jun 4, 2023

Conversation

jmelou
Copy link
Member

@jmelou jmelou commented Dec 21, 2022

@jmelou jmelou marked this pull request as draft December 21, 2022 14:11
@fcastan fcastan force-pushed the dev_ps branch 2 times, most recently from 1f9a911 to 2faa29a Compare April 12, 2023 07:41
@fabiencastan fabiencastan mentioned this pull request Apr 15, 2023
Closed
jmelou and others added 19 commits May 30, 2023 15:48
@jmelou @cbentejac
[photometricStereo] Add nodes for PS
1f49766
@jmelou @cbentejac
[ps] Add sphere selection in interface
0bd63b2
@jmelou @cbentejac
New node : sphere detection
70fc61c 
Sphere detection is made in a new node.
The LightingCalibration node takes now a json as input, and only
calibrates lighting
@jmelou @cbentejac
Interraction with node sphereDetection
0718115
@jmelou @cbentejac
[LightingCalibration] Add new method parameters
05f66fa
@jmelou @cbentejac
[RTI] Add PS from RTI dome node
62e0bc5
@jmelou @cbentejac
[RTI] Add RTI node
e1ea9f7
@jmelou @cbentejac
[RTI] Change RTI node file name
d0ff0e8
@jmelou @cbentejac
[pipeline] Add RTI pipeline
62570bd
@jmelou @cbentejac
[pipeline] New PS pipeline
8ccff7b
@fabiencastan @cbentejac
[nodes] PhotometricStereo: declare output sfmData
18b2894
@fabiencastan @cbentejac
[pipeline] Stereophotometry: Update release version
bdd2d06
@jmelou @cbentejac
[PS] Remove options for first version
bfd1db8
@jmelou @cbentejac
[nodes] PS: Expose normal and albedo maps in Viewer
5e49ee3
@jmelou @cbentejac
[PS] Fuse RTI and PS nodes part. 2
c983629
@jmelou @cbentejac
[PS] Add outputs to PS node
91bb5e5
@jmelou @cbentejac
[PS] Add some description, correct some typo
3d333ac
@fabiencastan @cbentejac
[nodes] remove RTI node and pipeline as it is integrated in photometr…
a89b36d 
…icStereo
@fabiencastan @cbentejac
[nodes] SphereDetection: use env var for model by default
0ee4d1f
@fabiencastan fabiencastan added this to the Meshroom 2023.2.0 milestone Jun 3, 2023
@fabiencastan fabiencastan marked this pull request as ready for review June 3, 2023 15:02
@fabiencastan fabiencastan merged commit 45ae444 into develop Jun 4, 2023
@fabiencastan fabiencastan deleted the dev_ps branch June 4, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

Assignees
No one assigned
Labels
majorFeature
Projects
None yet
Milestone
Meshroom 2023.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jmelou @fabiencastan @cbentejac