Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] ImageGallery: fix the DB path in the "Edit Sensor Database" dialog #1860

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

cbentejac
Copy link
Contributor

Description

When opening the dialog to edit the sensor database, the displayed path of the database was not resolved. Instead, the environment variable that contains it was displayed:

This PR displays the resolved path to the sensor database instead. As a direct consequence, the "Copy Path" button does indeed copy the absolute path to the sensor database (rather than the environment variable itself), and the "Open in External Editor" button can be used again to open the database in the set editor.

The output of "cameraInit.attribute("sensorDatabase").value" is the
unresolved ${ALICEVISION_SENSOR_DB} environment variable.

To get the path, the variable needs to be evaluated.
Copy link
Contributor

@mugulmd mugulmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are working fine, however the "Open in external editor" button did not work, but this is does not seem to be related to this PR.

@cbentejac
Copy link
Contributor Author

Changes are working fine, however the "Open in external editor" button did not work, but this is does not seem to be related to this PR.

If the "Open in External Editor" fails with error 31, it is because there is no application associated with the sensor database file type, and in that case it is expected (you should get a similar message if you were to try opening it directly in your file explorer). If the error is not an error 31, then it is not normal :)

@mugulmd
Copy link
Contributor

mugulmd commented Jan 9, 2023

Changes are working fine, however the "Open in external editor" button did not work, but this is does not seem to be related to this PR.

If the "Open in External Editor" fails with error 31, it is because there is no application associated with the sensor database file type, and in that case it is expected (you should get a similar message if you were to try opening it directly in your file explorer). If the error is not an error 31, then it is not normal :)

It was an error 31 indeed, thanks :)

Copy link
Contributor

@sbrood sbrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working perfectly now ! 👍

@fabiencastan fabiencastan added this to the Meshroom 2023.1.0 milestone Jan 14, 2023
@fabiencastan fabiencastan merged commit d883e61 into develop Jan 14, 2023
@fabiencastan fabiencastan deleted the fix/sensorDBPath branch January 14, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants