[ui] Intrinsics: Fix warnings and exceptions #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sics table This commit fixes an "Unable to assign QJSValue to QObject*". In IntrinsicDisplayDelegate, initialize the "attribute" variant to null and set it as a parameter during the instantiation in ImageGallery. All references to "model.display" in IntrinsicDisplayDelegate have been replaced with a correct use of "attribute".
The metadata value of the viewpoint is meant to be a string, but if the viewpoint attribute has already been removed and does not exist anymore, then the metadata value becomes a PySide property. When trying to access that property, an exception is raised. This commit avoids raising exceptions in that case by checking that the viewpoint attribute still exists (the metadata value is a string instance) before accessing the metadata value. This fixes the "Failed to parse Viewpoint metadata: 'the JSON object must be str, bytes or bytearray, not Property'" warning raised by the exception which occurred every single time there was a switch between cameraInit groups that had been cleared.
fabiencastan
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a QML warning and a raised exception related to the intrinsics:
attributevariant in the intrinsics table.